[Backport 2.14.1] feat: add cpu model dropdown for harvester REK2 cluster provisioning#17161
Conversation
Signed-off-by: Andy Lee <[email protected]>
a110605
changed the title
a110605
changed the title
richard-cox
left a comment
richard-cox
left a comment
There was a problem hiding this comment.
Would you be able to fill in the template?
Would you also be able to provide the contents of that harvester-system/node-cpu-model-configuration configmap (saves me upgrading my local harvester)?
|
|
||
| const modelEntries = Object.entries(cpuModelsData.models || {}); | ||
|
|
||
| modelEntries.sort((a, b) => a[0].localeCompare(b[0])); |
There was a problem hiding this comment.
how come we sort modelEntries but not globalModels?
| networks: this.$store.dispatch('cluster/request', { url: `${ url }/k8s.cni.cncf.io.network-attachment-definitions` }), | ||
| storageClass: this.$store.dispatch('cluster/request', { url: `${ url }/${ STORAGE_CLASS }es` }), | ||
| settings: this.$store.dispatch('cluster/request', { url: `${ url }/${ MANAGEMENT.SETTING }s` }), | ||
| cpuModelConfig: this.$store.dispatch('cluster/request', { url: `${ url }/${ CONFIG_MAP }s/harvester-system/node-cpu-model-configuration` }), |
There was a problem hiding this comment.
if server-side pagination for config maps is ...
- disabled - we're already fetching all config maps
- enabled - we're fetching specific config maps, this one can just be added to that list
so in both cases we can avoid this request
There was a problem hiding this comment.
The configmap looks like below, it was added in harvester v1.8.0. 
|
Signed-off-by: Andy Lee <[email protected]>
|
@a110605 can you send me the configmap yaml? |
|
@a110605 Remember to forward port / update |
2 participants
Summary
Fixes #16724
Occurred changes and/or fixed issues
backport #17041 to release-2.14
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Add CPU Model dropdown in harvester RKE2 provisioning create page
The VM created on harvester
Checklist
Admin,Standard UserandUser Base